- Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) 02 Mar '26

02 Mar '26

Thanks, I pointed out a few minor issues. Otherwise this looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130902

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) 02 Mar '26

02 Mar '26

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > return STATUS_INVALID_PARAMETER; > } > + > if ((dig = get_digest_from_id( pad->pszAlgId )) == GNUTLS_DIG_UNKNOWN) > { > FIXME( "hash algorithm %s not recognized\n", debugstr_w(pad->pszAlgId) ); > return STATUS_NOT_SUPPORTED; > } > > - label.data = pad->pbLabel; > - label.size = pad->cbLabel; > - if ((status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ))) return status; > + /* Only set OAEP SPKI params for non-empty labels. > + * For empty labels, use backend defaults for compatibility. */ > + if (pad->pbLabel && pad->cbLabel) > + { Same here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130898

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) 02 Mar '26

02 Mar '26

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > return !params->output ? STATUS_SUCCESS : STATUS_BUFFER_TOO_SMALL; > } > > - if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP) > + if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP)) > { > BCRYPT_OAEP_PADDING_INFO *pad = params->padding; > gnutls_digest_algorithm_t dig; > gnutls_datum_t label; > > - if (!pad || !pad->pszAlgId || !pad->pbLabel) > + /* Size-only OAEP queries can succeed without padding info, but an actual > + * OAEP encryption call requires padding info on native Windows. */ And here as well. Comments should generally be used to point out non-obvious facts. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130900

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) 02 Mar '26

02 Mar '26

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > gnutls_datum_t label; > > - if (!pad || !pad->pszAlgId || !pad->pbLabel) > + /* Size-only OAEP queries can succeed without padding info, but an actual > + * OAEP encryption call requires padding info on native Windows. */ > + if (!pad) > { > WARN( "padding info not found\n" ); > return STATUS_INVALID_PARAMETER; > } > + > + if (!pad->pszAlgId) > + { > + WARN( "padding hash not found\n" ); > + return STATUS_INVALID_PARAMETER; > + } Splitting these checks just to print a slightly different message is not worth it. This is unlikely to happen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130901

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) 02 Mar '26

02 Mar '26

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > { > FIXME( "hash algorithm %s not recognized\n", debugstr_w(pad->pszAlgId) ); > return STATUS_NOT_SUPPORTED; > } > > - label.data = pad->pbLabel; > - label.size = pad->cbLabel; > - if ((status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ))) return status; > + /* Only set OAEP SPKI params for non-empty labels. > + * For empty labels, use backend defaults for compatibility. */ > + if (pad->pbLabel && pad->cbLabel) > + { > + label.data = pad->pbLabel; > + label.size = pad->cbLabel; > + status = privkey_set_rsa_oaep_params( key_data(params->key)->a.privkey, dig, &label ); > + if (status == STATUS_NOT_SUPPORTED) status = STATUS_SUCCESS; /* Function not available, use defaults */ And here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130899

1 0

Re: [PATCH v3 0/1] MR10222: bcrypt: Improve RSA OAEP parameter handling.
by Hans Leidekker (＠hans) 02 Mar '26

02 Mar '26

Hans Leidekker (@hans) commented about dlls/bcrypt/gnutls.c: > int ret; > > - if (params->key->alg_id == ALG_ID_RSA && params->flags & BCRYPT_PAD_OAEP) > + if (params->key->alg_id == ALG_ID_RSA && (params->flags & BCRYPT_PAD_OAEP)) > { > BCRYPT_OAEP_PADDING_INFO *pad = params->padding; > gnutls_digest_algorithm_t dig; > gnutls_datum_t label; > > + /* For OAEP decryption Windows requires a padding info structure with a hash > + * algorithm; label may be empty (pbLabel == NULL and cbLabel == 0). */ > if (!pad || !pad->pszAlgId) > { > WARN( "padding info not found\n" ); > return STATUS_INVALID_PARAMETER; > } The comment is not very useful as it only states what the code does. Please remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10222#note_130897

1 0

[PATCH v2 0/6] MR10204: cfgmgr32: Get rid of setupapi dependency in DevObject* implementation (2/2).
by Rémi Bernon (＠rbernon) 02 Mar '26

02 Mar '26

-- v2: cfgmgr32: Enumerate the registry keys directly in enum_dev_objects. cfgmgr32: Return LSTATUS from enum_dev_objects callback. cfgmgr32: Use the new helpers to read device interface properties. cfgmgr32: Use the new helpers to get device interface property keys. cfgmgr32: Return BOOL from devprop_filter_matches_properties. cfgmgr32: Initialize device_interface structs in DEV_OBJECT functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/10204

2 7

[PATCH 0/2] MR10215: Improve mouse in pointer message flags
by Huw Davies (＠huw) 02 Mar '26

02 Mar '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10215

4 4

[PATCH v6 0/5] MR10126: mf: Implement Scrubbing in SAR.
by Brendan McGrath (＠redmcg) 02 Mar '26

02 Mar '26

This MR adds the `IMFPresentationTimeSource` interface to SAR and adds support for scrubbing. -- v6: mf: Report requested seek time until seek is complete. mf: Implement Scrubbing in SAR. mf: Check provided presentation clock has a time source. mf: Implement presentation time source for SAR. mf: Replace state variable with clock_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/10126

2 7

[PATCH v3 0/19] MR10221: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) 01 Mar '26

01 Mar '26

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- v3: Edit loader.c - revise comment to attempt one more commit This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/10221

1 0