- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR9778: wined3d: Keep a reference on the swapchain the DC is borrowed from. - closed
by Rémi Bernon (＠rbernon) 18 Dec '25

18 Dec '25

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9778

1 0

Re: [PATCH v2 0/1] MR9778: wined3d: Keep a reference on the swapchain the DC is borrowed from.
by Rémi Bernon (＠rbernon) 18 Dec '25

18 Dec '25

Right, this seems to actually be a problem with the swapchain being recreated for the same window and the context not updating its DC... Although the swapchain pointer in the context seem quite brittle as it doesn't own any reference to it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9778#note_125838

1 0

[PATCH v5 0/3] MR9732: ntdll: Support FSCTL_DUPLICATE_EXTENTS_TO_FILE
by nikita pushkarev (＠strudelll) 18 Dec '25

18 Dec '25

Implement FSCTL_DUPLICATE_EXTENTS_TO_FILE handling in ntdll on Linux by wiring the IOCTL to FICLONERANGE/FICLONE where available and returning STATUS_INVALID_DEVICE_REQUEST otherwise. Adds the necessary constants/types when missing. -- v5: ntdll: Reuse fstatfs result in volume attribute query. https://gitlab.winehq.org/wine/wine/-/merge_requests/9732

4 7

Re: [PATCH v2 0/1] MR9778: wined3d: Keep a reference on the swapchain the DC is borrowed from.
by Elizabeth Figura (＠zfigura) 18 Dec '25

18 Dec '25

Wait, I'm more confused the more I think about this. How can we be presenting if a swapchain is destroyed? If we switch swapchains we should change context->dc, no? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9778#note_125828

1 0

Re: [PATCH 0/1] MR9769: nsiproxy.sys: Assign the highest metric value to loopback adapters. - approved
by Paul Gofman (＠gofman) 18 Dec '25

18 Dec '25

This merge request was approved by Paul Gofman. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9769

1 0

Re: [PATCH 0/1] MR9769: nsiproxy.sys: Assign the highest metric value to loopback adapters.
by Paul Gofman (＠gofman) 18 Dec '25

18 Dec '25

I was worrying that it may be treated as negative value by some apps rather than being too big. But yes, we have those bogus '-1' here and there and are probably to address those at once for all the cases later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9769#note_125815

1 0

Re: [PATCH 0/1] MR9769: nsiproxy.sys: Assign the highest metric value to loopback adapters.
by Hans Leidekker (＠hans) 18 Dec '25

18 Dec '25

It has to be '-1' for this bug. We have used this value for a long time so I'm not too worried about apps tripping over such a high value. If we do find them we could scale the values down to the 0-100 range or so (I've seen 25 for an ethernet adapter and 75 for the loopback adapter). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9769#note_125814

1 0

[PATCH 0/1] MR9795: comctl32: Set default acceleration values for up-down controls.
by Sven Baars (＠sbaars) 18 Dec '25

18 Dec '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57516 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9795

3 2

Re: [PATCH 0/1] MR9769: nsiproxy.sys: Assign the highest metric value to loopback adapters.
by Paul Gofman (＠gofman) 18 Dec '25

18 Dec '25

I see, thanks. I did a bit of ad-hoc tests to see the metrics in both GetAdapterAddresses and GetIpForwardTable, and while the values between the two are different on Windows (unlike Wine), loopback has the higher value in GetIpForwardTable on Windows as well. My slight concern is that '-1' value looks special and not something I ever observe on Windows. Maybe we'd ideally go with some other value, like INT_MAX for such cases, will that work for the bug? We get '-1' on Linux now for some cases, e. g., here it is the case for interfaces not connected to network (Windows still has low values for those interfaces and e. g. my unplugged 'eth0' appears first in GetAdaptersAddresses with metric of 5). I guess we'd ideally want to fixup those too for some int-positive values? But just setting loopback metric to INT_MAX should work too I guess to fix the present bug, '-1' for other interfaces looks not directly related. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9769#note_125811

1 0

Re: [PATCH 0/1] MR9769: nsiproxy.sys: Assign the highest metric value to loopback adapters.
by Hans Leidekker (＠hans) 18 Dec '25

18 Dec '25

It's adapter order from GetAdapterAddesses(). Linux doesn't have a concept of interface metric so we have to pick some value. The Windows machines I checked consistently assign a higher metric to the loopback interface compared to the ethernet interface so it sorts after and it's clear that applications depend on getting a non-loopback adapter first. This user's is running Wine in a container and the adapter with a routeable address in that container gets the highest metric which means that after that commit the loopback adapter sorts before it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9769#note_125810

1 0