- Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 20 Aug '23

20 Aug '23

> Actually, did you test this with a custom source? No. I will look into that. Thanks. > depending on a the player state it's either Stop->Start->Pause or Stop->Start IMFMediaSession::Start() always starts the session though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42793

1 0

[PATCH v2 0/1] MR3403: server: Revert "server: Avoid using SOL_IPX to detect whether IPX is supported."
by Fotios Valasiadis (＠fvalasiad) 20 Aug '23

20 Aug '23

This reverts commit 41cc117b3f37ab4b9b4ac8a815cd2a496d38fb4b. This commit broke musl support. With the changes introduced, the following code evaluates to the #else branch without checking for SO_DEFAULT_HEADERS resulting in an error. server/sock.c +1888 ``` \#ifdef HAS_IPX int ipx_type = protocol - WS_NSPROTO_IPX; \#ifdef SOL_IPX setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) ); \#else struct ipx val; /* Should we retrieve val using a getsockopt call and then * set the modified one? */ val.ipx_pt = ipx_type; setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) ); \#endif \#endif ``` I propose reverting the commit, but we could probably alter the macro in the code section provided to match the changes relevant github issue: https://github.com/void-linux/void-packages/pull/45202 Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- v2: server: Check for SO_DEFAULT_HEADERS before using it. https://gitlab.winehq.org/wine/wine/-/merge_requests/3403

4 10

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 20 Aug '23

20 Aug '23

Actually, did you test this with a custom source? What I see on Windows is that Start(new_position): * stops the source; * flushes; * starts again with new position. I noticed this extra stop when I tried mfplay API to see what SetPosition() is doing - depending on a the player state it's either Stop->Start->Pause or Stop->Start. Turns out this might be what session does internally. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42791

1 0

[PATCH v3 0/2] MR3525: ntdll: allow NULL timeout in NtCreateNamedPipeFile.
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Aug '23

20 Aug '23

Saw that this was allowed on MSDN and checked with a windows machine -- v3: ntdll/tests: Add NULL timeout test for NtCreateNamedPipeFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/3525

2 3

[PATCH v10 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 19 Aug '23

19 Aug '23

I have covered implementation with additional test cases. -- v10: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

3 3

[PATCH 0/1] MR3603: windowscodecs: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 19 Aug '23

19 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3603

3 2

[PATCH 0/1] MR3611: gdiplus: set Tahoma font in case MS Sans Serif is missing
by Bartosz Kosiorek (＠gang65) 18 Aug '23

18 Aug '23

It seems that Tahoma is better replacement than Arial in Wine, even if it is implemented in that way in native library. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55421 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3611

2 1

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598

1 0

Re: [PATCH v3 0/4] MR3538: wined3d: Move zero swapchain parameter fixup to wined3d_swapchain_state_init. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3538

1 0

Re: [PATCH v4 0/1] MR3608: mshtml: Check for non-NULL plugin host before trying to hold ref. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

1 0