- Wine-gitlab - list.winehq.org

[PATCH 0/10] MR9503: winemac: Allow Wine logging functions to be used from ObjC and non-Wine threads.
by Brendan Shanks (＠bshanks) 24 Nov '25

24 Nov '25

The goal of this MR is to allow the use of Wine’s logging functions by ObjC code (including from the main thread or other non-Wine threads). winemac’s ObjC code has almost no logging; often the first task when working on an issue is to add temporary logging traces to the ObjC code. By making the full ERR/WARN/TRACE/FIXME and debug channel functionality available, we can add TRACEs to delegate methods, etc. and put them in the right channels. Including Wine and Win32 headers in ObjC code does need a workaround for BOOL, which is both an ObjC and Win32 type. Part of the solution is to use the C99 ‘bool’ type wherever possible. Otherwise, BOOL is #defined to WINBOOL while Win32 headers are #included, and must be used in function signatures if a Win32 BOOL is needed. Creating a debug_info for non-Wine threads was straightforward, though with the limitation that timestamp/pid/tid are not supported. Note that previously macdrv_cocoa.h was included by both C and ObjC files, but macdrv.h was only included by C files. macdrv.h is now included by ObjC files as well, and merging the two header files can be done next. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9503

3 14

[PATCH v3 0/5] MR9558: d2d1: Add some new effect stubs
by Alfred Agrell (＠Alcaro) 24 Nov '25

24 Nov '25

Needed by https://store.steampowered.com/app/1138210/Esperia__Uprising_of_the_Scarlet… demo (and presumably the full game too); without this, it throws a message box saying No Interface | 1 | 88990028 on first entry to any combat (the 1 varies depending on which specific effect is unimplemented), then segfaults if any character gets a critical hit (those are prefixed with a bar showing the character's eyes). Even with these stubs, the game looks glitched when getting a crit, but better ugly than segfault. The game also needs Color Matrix, Gaussian Blur and Flood effects relative to Proton 10, but those three were already stubbed in Wine 10.n. -- v3: d2d1: Add Saturation effect stub d2d1: Add Hue Rotation effect stub d2d1: Add Directional Blur effect stub d2d1: Add Brightness effect stub https://gitlab.winehq.org/wine/wine/-/merge_requests/9558

3 6

[PATCH v3 0/3] MR8925: winemac.drv: Add EDID support.
by Jactry Zeng (＠jactry) 23 Nov '25

23 Nov '25

-- v3: winemac.drv: Support to generate EDID from display parameters from Core Graphics APIs. winemac.drv: Support to get EDID from IODisplayConnect. winemac.drv: Support to get EDID from DCPAVServiceProxy. https://gitlab.winehq.org/wine/wine/-/merge_requests/8925

3 5

[PATCH 0/1] MR9562: vkd3d: Import upstream release 1.18.
by Alexandre Julliard (＠julliard) 23 Nov '25

23 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9562

5 5

[PATCH v5 0/7] MR9560: rometadata: IMetaDataImport implementation, part 2
by Vibhav Pant (＠vibhavp) 23 Nov '25

23 Nov '25

-- v5: rometadata: Implement IMetaDataImport::GetCustomAttributeByName. https://gitlab.winehq.org/wine/wine/-/merge_requests/9560

2 7

[PATCH 0/1] MR9561: ntdll/tests: Avoid out-of-bounds read in call_virtual_unwind_x86 (ASan).
by Bernhard Übelacker 23 Nov '25

23 Nov '25

In `call_virtual_unwind_x86` in `unwind_size` a size to read 16 bytes is determined. This patch simply allocates that much bytes in the source variable. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161010) [ASan report in gitlab CI](https://gitlab.winehq.org/bernhardu/wine/-/jobs/210659/viewer#L14266) <details> <summary>ASan details</summary> ``` $ wine dlls/ntdll/tests/x86_64-windows/ntdll_test.exe unwind ================================================================= ==392==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0001402cdf86 at pc 0x6ffffe8cc0eb bp 0x7ffffe1fdbb0 sp 0x7ffffe1fdbf8 READ of size 16 at 0x0001402cdf86 thread T0 #0 0x6ffffe8cc0ea in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt\lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x0001401b02d0 in call_virtual_unwind_x86 .../wine/dlls/ntdll/tests/unwind.c:2730 #2 0x0001401ad7ab in test_virtual_unwind_x86 .../wine/dlls/ntdll/tests/unwind.c:3371 #3 0x0001401ad602 in func_unwind .../wine/dlls/ntdll/tests/unwind.c:3767 #4 0x0001401e4242 in run_test .../wine/include/wine/test.h:780 #5 0x0001401e3c4b in main .../wine/include/wine/test.h:900 #6 0x0001401e5eda in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #7 0x6fffffc67a54 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a54) #8 0x6fffffde06d6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506d6) 0x0001402cdf86 is located 26 bytes before global variable 'test_virtual_unwind_x86.results_6_epilogue' defined in '.../wine/dlls/ntdll/tests/unwind.c:3166' (0x0001402cdfa0) of size 336 0x0001402cdf86 is located 0 bytes after global variable 'test_virtual_unwind_x86.unwind_info_6' defined in '.../wine/dlls/ntdll/tests/unwind.c:3156' (0x0001402cdf80) of size 6 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/ntdll/tests/unwind.c:2730 in call_virtual_unwind_x86 ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9561

1 1

[PATCH v4 0/7] MR9560: rometadata: IMetaDataImport implementation, part 2
by Vibhav Pant (＠vibhavp) 23 Nov '25

23 Nov '25

-- v4: rometadata: Implement IMetaDataImport::GetCustomAttributeByName. rometadata: Implement IMetaDataTables::{EnumProperties, GetPropertyProps}. rometadata: Implement IMetaDataDispenser::OpenScopeOnMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9560

2 7

[PATCH v3 0/7] MR9560: rometadata: IMetaDataImport implementation, part 2
by Vibhav Pant (＠vibhavp) 23 Nov '25

23 Nov '25

-- v3: rometadata: Implement IMetaDataImport::GetCustomAttributeByName. rometadata: Implement IMetaDataTables::{EnumProperties, GetPropertyProps}. rometadata: Implement IMetaDataDispenser::OpenScopeOnMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9560

2 7

[PATCH v3 0/2] MR9519: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier.
by Bernd Herd (＠herdsoft) 22 Nov '25

22 Nov '25

64-Bit Windows applications typically expect the Twain Data Source manager to be named twaindsm.dll. Send the DG_CONTROL/DAT_ENTRYPOINT/MSG_SET before DG_CONTROL/DAT_IDENTITY/MSG_OPENDS so sane.ds does not need to know the module name to find the DSM entry point. An explanation for the request to offer the name twaindsm.dll for 64-Bit windows is offered here by the TWAIN organization: https://github.com/twain/twain-dsm/blob/master/TWAIN_DSM/src/readme.doc They cannot update the twain_32.dll installed and maintained by Microsoft, so they choose the new name twaindsm.dll instead. This name is also used at least by Irfanview and oder versions oder LibreOffice (Newer Libreoffice version start a 32-Bit process for 32-Bit TWAIN usage). This Merge request also changes the twain_32.dll so that it send it's entry points earlier, before opening the data source. This is the same behaviour as the twaindsm.dll from the TWAIN organization from [https://github.com/twain/twain-dsm/](https://github.com/twain/twain-dsm/blo… Otherwise sane.ds would in MSG_OPENDS try to find the DSM entry point based on the module-name "twain_32" in sane_main.c:60: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); if (!SANE_dsmentry) { ERR("can't find DSM entry point\n"); return TWRC_FAILURE; } } ``` -- v3: dlls/twain_32, dlls/twaindsm: Build Twain DSM as twaindsm.dll on 64-Bit build dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier. https://gitlab.winehq.org/wine/wine/-/merge_requests/9519

4 6

[PATCH 0/3] MR9557: ntdll: Support iterative barrier usage without re-initialization.
by Paul Gofman (＠gofman) 22 Nov '25

22 Nov '25

https://bugs.winehq.org/show_bug.cgi?id=59017 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9557

3 5