- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/0] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

[PATCH 0/1] MR1849: winebus.sys: Declare a variable only when used
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

udev_add_device declares a variable (product) even when it is not used on all platforms. Use the same condition for the declaration that already guards the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

2 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Zhiyi Zhang (＠zhiyi) 20 Dec '22

20 Dec '22

Zhiyi Zhang (@zhiyi) commented about include/pathcch.h: > HRESULT WINAPI PathCchStripPrefix(WCHAR *path, SIZE_T size); > HRESULT WINAPI PathCchStripToRoot(WCHAR *path, SIZE_T size); > BOOL WINAPI PathIsUNCEx(const WCHAR *path, const WCHAR **server); > + > +#ifdef __cplusplus > +} > +#endif Please add a new line here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19897

1 0

[PATCH 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

2 2

[PATCH 0/1] MR1848: wmc: Avoid uninitialized variable in init_argv0_dir
by Gerald Pfeifer (＠gerald) 19 Dec '22

19 Dec '22

init_argv0_dir has conditional code for different operating systems. In case of FreeBSD a variable remains uninitialized in the error case, yet is then used. Fix that by handling the error case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1848

2 1

Re: [PATCH v2 0/1] MR1845: winhttp: Check for NULL lpszAutoConfigUrl in WinHttpGetProxyForUrl(). - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1845

1 0

Re: [PATCH v3 0/3] MR1824: Remove broken from some color tests that can also fail on Linux. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

1 0

Re: [PATCH v3 0/5] MR1843: user32: Add more EnableMouseInPointer / GetPointerType / GetPointerInfo tests. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1843

1 0

Re: [PATCH v5 0/7] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

1 0

Re: [PATCH v2 0/1] MR1840: ntdll: Only compile get_current_teb() on linux. - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1840

1 0