- Wine-gitlab - list.winehq.org

Re: [PATCH v5 0/7] MR906: msvcr: Implement _StructuredTaskCollection::_RunAndWait and the constructor - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/906

1 0

Re: [PATCH v2 0/2] MR1744: wofutil: Stub WofShouldCompressBinaries(). - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1744

1 0

Re: [PATCH v2 0/3] MR1742: win32u: A bit more user32 conversion - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1742

1 0

Re: [PATCH v3 0/1] MR1736: taskschd/tests: Fix test failures on newer version of Windows 10. - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1736

1 0

Re: [PATCH v4 0/1] MR1701: wshom.ocx: Implement IWshNetwork2_get_UserName(). - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1701

1 0

Re: [PATCH v2 0/1] MR1743: wtsapi32: Improve the stub for WTSQuerySessionInformation(WTSClientProtocolType). - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1743

1 0

Re: [PATCH v2 0/1] MR1734: kernel32/tests: Avoid failures when processes start during the process test. - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1734

1 0

Re: [PATCH v2 0/1] MR1735: include: Add corecrt_malloc.h. - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1735

1 0

Re: [PATCH v2 0/1] MR1741: winhttp/tests: Reduce send buffer size. - approved
by Alexandre Julliard (＠julliard) 08 Dec '22

08 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1741

1 0

[PATCH 0/7] MR1752: Draft: RFC: Make syscall functions sysv_abi on x64
by Torge Matthies (＠tmatthies) 08 Dec '22

08 Dec '22

This removes 20 `movaps` instructions from every syscall that calls a sysv_abi function, plus an `and` for stack alignment and some other instructions depending on the function. In `NtAllocateLocallyUniqueId` for example this reduces the number of instructions from 63 to 36. I don't entirely understand the llvm-mca output but here are the before and after stats that it outputs for that function: Before Iterations: 100 Instructions: 6300 Total Cycles: 3335 Total uOps: 6300 Dispatch Width: 6 uOps Per Cycle: 1.89 IPC: 1.89 Block RThroughput: 15.0 After Iterations: 100 Instructions: 3600 Total Cycles: 1514 Total uOps: 3600 Dispatch Width: 6 uOps Per Cycle: 2.38 IPC: 2.38 Block RThroughput: 6.0 This currently depends on the stack being aligned by the syscall dispatcher, which afaict is the case if `sizeof(struct syscall_frame) % 16 == 0`. If that is not good enough I can add an `andq $~15,%rsp` somewhere. One question I have is whether we want to continue supporting CDECL syscalls (only `wine_server_call`, `wine_server_fd_to_handle` and `wine_server_handle_to_fd`)? If we do, this adds a bit of complexity to the syscall dispatcher, see the commit "FIXUP ntdll: Support CDECL syscalls." If we don't, and make those syscalls WINAPI instead, then for every call to those functions on x86 it seems to either change nothing or add one `add` instruction. However we of course lose the ability to make CDECL syscalls. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1752

3 9