- Wine-gitlab - list.winehq.org

[PATCH v2 0/10] MR1582: winhttp: Read server reply in send_request().
by Paul Gofman (＠gofman) 06 Dec '22

06 Dec '22

It turns out that WinHttpReceiveResponse() completes synchronously in async mode (unless recursive request for handling authorization or redirect is involved). Some apps depend on that and do not wait for WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE, calling WinHttpQueryHeaders() or WinHttpWebSocketCompleteUpgrade() right after calling WinHttpReceiveResponse, relying on that to finish synchronously. My initial out of tree testing shows that no network communication is performed during WinHttpReceiveResponse() call (when recursive request is not involved). I tested that by inserting a wait between WinHttpSendRequest and WinHttpReceiveResponse and disabling network connection during the wait. WinHttpReceiveResponse still succeeds on Windows. I think the above means that the actual response receiving from server is performed during WinHttpSendRequest. WinHttpReceiveResponse is not a complete no-op however. As shown by the existing tests the notifications related to receiving response are still delivered during WinHttpReceiveResponse (albeit in the same thread). Also WinHttpReceiveResponse affects request state: querying headers or upgrading to websocket without calling WinHttpReceiveResponse does not succeed. When redirect is involved, all the WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE, WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED and WINHTTP_CALLBACK_STATUS_REDIRECT notifications are delivered synchronously from the calling thread. Then, the new request send notifications and response receiving notifications are delivered from the new thread. An interesting case is when WinHttpReceiveResponse is called from SendRequest callbacks in async mode. If WinHttpReceiveResponse is called from WINHTTP_CALLBACK_STATUS_SENDING_REQUEST or WINHTTP_CALLBACK_STATUS_REQUEST_SENT (i. e., when request is not complete yet), calling WinHttpReceiveResponse() suddenly succeeds an shows the following message sequence (that is partially reflected in the tests I am adding): - calling WinHttpReceiveResponse from WINHTTP_CALLBACK_STATUS_SENDING_REQUEST (which is already called on the async thread on Win10, thread A). Win8 queues WINHTTP_CALLBACK_STATUS_SENDING_REQUEST synchronously and goes async a bit later. - WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE, thread A; - WinHttpReceiveResponse() returns to the caller WINHTTP_CALLBACK_STATUS_REQUEST_SENT callback; returning from user callback; - WINHTTP_CALLBACK_STATUS_REQUEST_SENT, thread A; - WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE (another thread, although the sequence is probably synced; I am not implementing this part and calling this callback from the same thread A); - WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED in thread A; - WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE in thread A. So the receive_response() state RECEIVE_RESPONSE_SEND_INCOMPLETE is primarily needed to handle this case. -- v2: winhttp/tests: Test calling WinHttpReceiveResponse() recursively from various send callbacks. winhttp/tests: Test WinHttpReceiveResponse() synchronous behaviour. winhttp: Execute receive_response() synchronously when possible. winhttp: Wait for WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE in request_send(). winhttp: Call receive_response() recursively instead of looping. winhttp: Factor out queue_receive_response(). winhttp: Receive server reply in send_request(). winhttp: Send notifications from receive_response() directly. winhttp: Don't refill buffer after receiving server response. winhttp: Do not open connection in handle_redirect(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1582

3 12

[PATCH 0/1] MR1691: kernel32/tests: Use the strcasecmp function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 06 Dec '22

06 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1691

3 2

[PATCH 0/2] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to strdup, wcsdup, _aligned_malloc
by Brendan Shanks (＠bshanks) 06 Dec '22

06 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

4 6

[PATCH 0/1] MR1690: include: Annotate CreateThreadpool* with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 06 Dec '22

06 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1690

2 1

[PATCH 0/1] MR1689: dbghelp: Annotate allocation functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 06 Dec '22

06 Dec '22

Apart from performance benefits, this gets us a nice warning if memory allocated by one of these functions is freed incorrectly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1689

2 1

[PATCH v2 0/2] MR54: vkd3d-shader/hlsl: Initialize static variables to 0 by default.
by Francisco Casas (＠fcasas) 05 Dec '22

05 Dec '22

We are currently not initializing static values to zero by default. Consider the following shader: ```hlsl static float4 va; float4 main() : sv_target { return va; } ``` we get the following output: ``` ps_5_0 dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, r1.xyzw mov o0.xyzw, r0.xyzw ret ``` where r1.xyzw is not initialized. This patch solves this by assigning the static variable the value of an uint 0, and thus, relying on complex broadcasts. This seems to be the behaviour of the the native compiler, since it retrieves the following error on a shader that lacks an initializer on a data type with object components: ``` error X3017: cannot convert from 'uint' to 'struct <unnamed>' ``` -- v2: vkd3d-shader/hlsl: Allow uninitialized static objects, as long as they are not referenced. vkd3d-shader/hlsl: Initialize static variables to 0 by default. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/54

3 8

Re: [PATCH v4 0/1] MR1630: wineusb.sys: Add support for TransferBufferMDL. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1630

1 0

Re: [PATCH v2 0/6] MR1664: Actually start enabling long integral types in wined3d. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1664

1 0

Re: [PATCH v5 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

1 0

Re: [PATCH v2 0/1] MR1677: quartz/tests: Remove redundant null check from testfilter_JoinFilterGraph. - approved
by Alexandre Julliard (＠julliard) 05 Dec '22

05 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1677

1 0