- Wine-gitlab - list.winehq.org

[PATCH 0/8] MR1558: localspl: Start moving print job related code to localspl
by Piotr Caban (＠piotr) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1558

3 9

[PATCH v3 0/5] MR1554: win32u: Reset focused item when removing menu item
by Vladislav Timonin (＠vt) 28 Nov '22

28 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split button dropdown - click on any item - clear dropdown items - open dropdown again Menu borked and won't open again. Source for the testing app for reproduction. [test.c](/uploads/2f703f63891b33e1a0eb0fcd27c912b7/test.c) I guess, the alternative is to reset focused item when menu is closed, but not sure where's the best place to do that, haven't dug deep enough. -- v3: win32u: Update focused item when inserting a menu item win32u: Reset focused item if it was removed when removing a menu item https://gitlab.winehq.org/wine/wine/-/merge_requests/1554

2 5

[PATCH 0/1] MR1573: winedump: Don't crash when dumping .dbg files.
by eric pouech (＠epo) 28 Nov '22

28 Nov '22

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1573

2 1

[PATCH 0/1] MR1572: ntdll: Detect ntdll module also by module path compatition.
by Jacek Caban (＠jacek) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1572

2 1

Re: [PATCH v6 0/2] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl 28 Nov '22

28 Nov '22

v4: - Removed format checking via texture creation. - Reworked the tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1046#note_17672

1 0

[PATCH v2 0/3] MR1549: configure: Clang build fixes.
by Jacek Caban (＠jacek) 28 Nov '22

28 Nov '22

I recently noticed problems with building with clang in msvc mode when using my distro clang. It seems specific to its configuration, I think that it doesn't affect default clang. One problem is that --rtlib=libgcc is specified in /etc/clang, which causes clang to produce: ``` clang-15: error: unsupported runtime library 'libgcc' for platform 'MSVC' ``` I think it's a clang bug here: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/… It should probably check for -nodefaultlibs in addition to -nostdlib. It's easy to handle on Wine side by using -nostdlib. The other problem is that clang for some reason doesn't define `_MSV_VER` by default. I found that it's defined only if I pass `-fuse-ld=lld` to the command line. That's weird because it shouldn't affect compilation step, it should matter only for linking and that's when we pass it. I didn't track it down in clang code itself, but if we can't depend on clang providing it by default, we need to make sure to pass `-fms-compatibility-version` ourselves. The exact version doesn't really matter, we mostly need to make sure that it's defined at all so that our #ifdefs work correctly. -- v2: configure: Use -fuse-ld=lld also for compilation targets. winegcc: Use -nostdlib instead of -nostartfiles on Clang MSVC targets. configure: Use -nostdlib instead of -nostartfiles in WINE_TRY_PE_CFLAGS. https://gitlab.winehq.org/wine/wine/-/merge_requests/1549

3 5

[PATCH v5 0/3] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl 28 Nov '22

28 Nov '22

-- v5: mfmediaengine: Add a fallback when the set engine format cannot be used to init samplegrabber. mfmediaengine: Only accept engine formats which are render target compatible. https://gitlab.winehq.org/wine/wine/-/merge_requests/1046

4 30

[PATCH 0/7] MR1571: wmvcore: Move async reader to wmvcore and add more threading tests.
by Rémi Bernon 28 Nov '22

28 Nov '22

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/1311, which will need to be updated according to pass the new tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1571

2 8

[PATCH 0/1] MR1562: wininet: Simplify memory allocation in HTTP_InsertCustomHeader.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1562

3 2

[PATCH 0/1] MR1563: mshtml: Remove string constant macros from navigate.c.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

Having an extra layer of indirection here makes the code less clear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1563

3 2