- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR1532: kernel32/profile: Trim spaces from section names on load. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1532

1 0

Re: [PATCH v3 0/4] MR1427: wined3d: Add a lower size bound for the streaming buffer allocation. - approved
by Alexandre Julliard (＠julliard) 24 Nov '22

24 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1427

1 0

[PATCH v2 0/1] MR1541: winevulkan: Don't try to convert unions without selectors.
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

-- v2: winevulkan: Don't try to convert unions without selectors. https://gitlab.winehq.org/wine/wine/-/merge_requests/1541

3 2

[PATCH 0/1] MR1541: winevulkan: Don't try to convert unions without selectors.
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1541

3 2

Re: [PATCH v2 0/2] MR1508: winevulkan: Union conversion and 1.3.235 spec update.
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

On Thu Nov 24 11:02:06 2022 +0000, Georg Lehmann wrote: > Yeah this is a bit unfortunate. Maybe we should just not support 32bit > ray tracing for now, if I recall correctly nvidia doesn't even support > it with their driver. Sure, 32bit ray tracing is probably not important on its own. But more generally, we can't reliably convert unions without selectors, so I'd suggest to express that in make_vulkan. I created !1541 that just skips them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1508#note_17374

1 0

[PATCH 0/8] MR1489: DirectMusic: Don't force a calling convention on internal functions.
by Alex Henrie (＠alexhenrie) 24 Nov '22

24 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1489

4 10

[PATCH 0/3] MR1536: Preparation to long types migration (serie II)
by eric pouech (＠epo) 24 Nov '22

24 Nov '22

Migration a couple of bits to unsigned int. Note to Zebediah (mainly on second commit of this serie): - there is also a load of 'uint32_t flags' parameters that I didn't change (mainly not to change too many things) Is this something to consider? - I didn't touch the local variables either. Maybe it's something to consider also. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1536

4 5

Re: [PATCH v2 0/1] MR1396: configure: On macOS, build the loader targeting 10.7 when preloader is used.
by Dean M Greer (＠Gcenx) 24 Nov '22

24 Nov '22

On Wed Nov 23 21:10:49 2022 +0000, Brendan Shanks wrote: > Yes, although I also reproduced it with a test app I built on Mojave. On > Mojave environ wasn’t NULL, on Monterey/Ventura it was. >From searching this seems to be a known issues since macOS 11.1 https://www.gnu.org/software/gnulib/manual/html_node/environ.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1396#note_17364

1 0

[PATCH v3 0/4] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host
by Jacek Caban (＠jacek) 24 Nov '22

24 Nov '22

This MR implements memory mapping for wow64 using VK_EXT_external_memory_host. This has some problems (more below), but overall, it looks promising as a stopgap. It passes D3D tests and works fine in general. For proper solution, we'd need a new Vulkan extension. I experimented with a prototype extension https://github.com/KhronosGroup/Vulkan-Docs/pull/1906 and it looks like we can make it work, my WIP implementation is here https://gitlab.winehq.org/jacek/wine/-/tree/vulkan-map-placed. However, it would be nice to have a fallback working on existing drivers as well. The main problem of this MR is that it breaks Vulkan spec. The main rule it breaks is that according to spec, we should explicitly specify that we plan to use external memory when creating VkBuffer or VkImage. The problem is that we don't know if we will until we bind memory to the buffer. I tried some workarounds for that (delaying actual buffer creation, recreating buffer when needed). I got it mostly working and passing tests without validation errors, but it was more invasive than I'd like and still had other problems. I'd rather avoid that if possible. After looking at Mesa sources, I think that the way this MR breaks the spec should be harmless for its drivers. I don't have the hardware to test with Nvidia. If it works there, I'm tempted to ignore spec violation for now, given that the right path forward is VK_EXT_map_memory_placed anyway. Performance-wise, this MR is sub-optimal because we're limited in what memory types we can use. However, I ran Unigine benchmarks on radv and the difference was marginal. In case of Heaven, it was even slightly faster on wow64, which could be explained by 64-bit Vulkan driver being generally slightly faster, but the difference is too small to draw any conclusion. The last patch is not meant for (eventual) merge, but it's nice for testing the concept. It makes it possible to force using external memory in any kind of Wine build to experiment with its effects without need for wow64. To test that, just set `WINEVULKAN_EXTERNAL_MEMORY` environment variable. -- v3: winevulkan: Introduce debugging environment variables. winevulkan: Use VK_EXT_external_memory_host extension to map memory on wow64. winevulkan: Wrap VkDeviceMemory. winevulkan: Don't try to unwrap missing optional handle struct members. https://gitlab.winehq.org/wine/wine/-/merge_requests/1502

3 6

[PATCH v2 0/2] MR1528: winhttp: Improve WinHttpGetProxyForUrl() execution time when wpad is not available
by Paul Gofman (＠gofman) 24 Nov '22

24 Nov '22

Fixes Marvel Snap being unable to connect to servers (part of it, another part is wmic patches), and maybe improves wait times in many other apps. Typically "http://wpad/..." (which is commonly requested as lpszAutoConfigUrl for WinHttpGetProxyForUrl) is not available and WinHttpGetProxyForUrl() is hanging for a really long time resolving this name in download_script(). On Windows 10 here the name resolution timeout is about 9sec (and I could not find a way to configure it for a longer timeout). On Linux default DNS timeouts are typically longer. Yet, while WinHttpGetProxyForUrl() execution time is not consistent here, when I run it right after reboot or after network interface reconnection it typically takes ~4-7 seconds to complete on the first run. Then, testing it again shortly after yields no noticeable timeout. I suppose Windows caches and manages that globally in some service, so maximum possible 9 seconds name resolution timeout is rarely hit. Since proxy config URL, if available, is supposed to be in the local network, having the timeout of 5 seconds for name resolution looks more than enough to me. -- v2: winhttp: Cache script in download_script(). winhttp: Set name resolution timeout in download_script(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1528

3 4