- Wine-gitlab - list.winehq.org

[PATCH 0/10] MR969: Draft: combase: CoMsgWaitForMultipleHandles message pump.
by Kevin Puetz (＠puetzk) 30 Sep '22

30 Sep '22

This sequence of patches fixes numerous corner cases in CoMsgWaitForMultipleHandles, particularly around the exact sequence in which signaled handles, windows messages, and APCs are considered and which "win" if more than one thing has happened at a time. This was previously submitted quite some time ago, and rejected as "Needs splitting": https://www.winehq.org/pipermail/wine-devel/2020-November/177529.html Sorry it has taken me so long to get back to this one, but here's an attempt to tease it apart into a number of smaller commits that each make smaller changes and add some of the new tests. Hopefully that makes it easier to follow which change fixes what. Apologies if the splitting is still a little tortured in places, since it re-thought all at once and then split apart, not developed in this order and then squashed. But hopefully this is more readable. Major fixes are: - closes a race condition with short/zero timeouts, in which it could reports RPC_S_PENDING without ever even checking the handles - cancellation via IMessageFilter::PendingMesage -> `PENDINGMSG_CANCELCALL` now actually exits the wait - makes sure not to pump additional messages after the handles have been signaled - don't use a MsgWait until after seeing that handles were not already signaled. This is mostly important to COWAIT_WAITALL. It's still not advisable to use COWAIT_WAITALL in an STA (for reasons all our favorite Microsoft Gurus have discussed: https://learn.microsoft.com/en-us/archive/blogs/larryosterman/things-you-sh… https://devblogs.microsoft.com/oldnewthing/20060127-17/?p=32493) But it gets fixed in passing as a consequence of the previous changes, and so there are some new conformance tests to show that the new behavior matches windows. There's also a some new `todo_wine` tests for spurious calls to IMessageFilter_MessagePending. This behavior has *not* changed, but I expanded the test coverage (unsuccessfully) hoping it would give me a hint about what should change. Since I still don't know what the rules should be, I left the new tests `todo_wine`. But maybe they'll be a useful hint someday. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/969

3 13

[PATCH 0/1] MR968: crypt32: Set correct exponent length in decoded BCRYPT_RSAKEY_BLOB.
by Paul Gofman (＠gofman) 29 Sep '22

29 Sep '22

Nvidia's Streamline library depends on that (https://github.com/NVIDIAGameWorks/Streamline/) I modified an exponent value in tests to a non sensual one which has non-symmetric byte sequence so the byte order also gets tested. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/968

2 1

[PATCH 0/5] MR25: vkd3d-shader/hlsl: Implement asuint() and completely move init_node() to hlsl.c.
by Zebediah Figura (＠zfigura) 29 Sep '22

29 Sep '22

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/25

4 7

[PATCH 0/1] MR967: winevulkan: Introduce conversion_context and use it for conversion memory allocation.
by Jacek Caban (＠jacek) 29 Sep '22

29 Sep '22

This simplifies the code as we don't need to worry about generating clean up functions for every conversion. It also makes allocations faster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/967

3 2

Re: [PATCH v2 0/1] MR961: winegstreamer: Respect debug channels configuration for error output. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/961

1 0

Re: [PATCH v2 0/1] MR960: windowscodecs: Redirect TIFF debug output to the Wine debug functions. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/960

1 0

Re: [PATCH v2 0/1] MR958: vbscript: don't abort when trying to TRACE() functions with many arguments. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/958

1 0

Re: [PATCH v5 0/7] MR856: mshtml: url prop for Storage Events and improvements. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/856

1 0

Re: [PATCH v3 0/13] MR929: mf/tests: More MF transform test factorization and small fixes. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/929

1 0

Re: [PATCH v3 0/1] MR938: dbghelp: SymFromName* should first look in local context. - approved
by Alexandre Julliard (＠julliard) 29 Sep '22

29 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/938

1 0