- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR744: winealsa.drv: Make functions static where possible.
by Huw Davies (＠huw) 31 Aug '22

31 Aug '22

Huw Davies (@huw) commented about dlls/winealsa.drv/alsa.c: > return key; > } > > -ULONG reg_query_value( HKEY hkey, const WCHAR *name, > +static ULONG reg_query_value( HKEY hkey, const WCHAR *name, > KEY_VALUE_PARTIAL_INFORMATION *info, ULONG size ) Could you correctly indent the second line? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/744#note_7335

1 0

[PATCH 0/1] MR746: static winex11
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

- kernelbase: Fix error value for PE files without resource. - include: Simplify handling of va_list in debug printf functions. - include: Add va_list version of the debug printf functions. - include: Avoid _t-suffixes. - include: Add list_move_after() and list_move_before(). - user32: Call winproc_init before dpiaware_init. - combase: Omit thread ID from the stub manager ipid for MTA objects. - d3dx10: Factor out image format conversion function. - d3dx10: Use WIC functions to obtain info about DDS image. - d3dx10: Add support for texture cubes in D3DX10CreateTexture functions. - d3dx10: Don't check frame count in load_texture_data. - d3dx10: Add support for loading MipLevels data in load_texture_data. - d3dx10/tests: Improve cube textures data testing. - winemac.drv: Rename display modes cache variables. - winemac.drv: Invalidate mode cache when enum flags changes. - winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. - winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. - winemac.drv: Support getting non-primary adapter current display mode. - winemac.drv: Support enumerating non-primary adapters display modes. - evr/filter: Implement pin's connect/disconnect. - d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - d3dx10/tests: Add a test for D3DX10PreprocessShaderFromMemory(). - wmvcore/tests: Use a constant for test.wmv duration. - wmvcore/tests: Test sync reader output settings read / write. - wmvcore/tests: Test async reader output settings read / write. - wmvcore/tests: Test that the callback thread is always the same. - wmvcore/tests: Test async reader compressed sample monotonic pts. - wmvcore/tests: Test async reader DedicatedDeliveryThread setting. - mshtml/tests: Fix a spelling error in an ok() message. - dbghelp: Fix a couple of spelling errors in a comment. - mscvpdb: Fix a spelling error in a comment. - winspool.drv/tests: Fix the spelling of a variable name. - winex11.drv: Make get_unix_file_name() static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/746

2 1

Re: [PATCH v5 0/11] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Giovanni Mascellani (＠giomasce) 31 Aug '22

31 Aug '22

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c: > > static void copy_propagation_invalidate_whole_variable(struct copy_propagation_var_def *var_def) > { > + unsigned int component_count = hlsl_type_component_count(var_def->var->data_type); > unsigned i; > > TRACE("Invalidate variable %s.\n", var_def->var->name); > > - for (i = 0; i < var_def->var->data_type->reg_size; ++i) > + for (i = 0; i < component_count; ++i) > var_def->values[i].state = VALUE_STATE_DYNAMICALLY_WRITTEN; > } > > -static void copy_propagation_set_value(struct copy_propagation_var_def *var_def, unsigned int offset, > - unsigned char writemask, struct hlsl_ir_node *node) > +static void copy_propagation_set_value(struct copy_propagation_var_def *var_def, unsigned int comp, For the future, please do code cleaning stuff (like renaming variables) in dedicated commits, so that the "meaty" commits are easier to read. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7#note_7330

1 0

[PATCH 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by jhol (＠jhol) 31 Aug '22

31 Aug '22

Based on a patch by Qian Hong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/745

2 1

[PATCH 0/7] MR743: static
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

- kernelbase: Fix error value for PE files without resource. - include: Simplify handling of va_list in debug printf functions. - include: Add va_list version of the debug printf functions. - include: Avoid _t-suffixes. - include: Add list_move_after() and list_move_before(). - user32: Call winproc_init before dpiaware_init. - combase: Omit thread ID from the stub manager ipid for MTA objects. - d3dx10: Factor out image format conversion function. - d3dx10: Use WIC functions to obtain info about DDS image. - d3dx10: Add support for texture cubes in D3DX10CreateTexture functions. - d3dx10: Don't check frame count in load_texture_data. - d3dx10: Add support for loading MipLevels data in load_texture_data. - d3dx10/tests: Improve cube textures data testing. - winemac.drv: Rename display modes cache variables. - winemac.drv: Invalidate mode cache when enum flags changes. - winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. - winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. - winemac.drv: Support getting non-primary adapter current display mode. - winemac.drv: Support enumerating non-primary adapters display modes. - evr/filter: Implement pin's connect/disconnect. - d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - d3dx10/tests: Add a test for D3DX10PreprocessShaderFromMemory(). - wmvcore/tests: Use a constant for test.wmv duration. - wmvcore/tests: Test sync reader output settings read / write. - wmvcore/tests: Test async reader output settings read / write. - wmvcore/tests: Test that the callback thread is always the same. - wmvcore/tests: Test async reader compressed sample monotonic pts. - wmvcore/tests: Test async reader DedicatedDeliveryThread setting. - mshtml/tests: Fix a spelling error in an ok() message. - dbghelp: Fix a couple of spelling errors in a comment. - mscvpdb: Fix a spelling error in a comment. - winspool.drv/tests: Fix the spelling of a variable name. - winealsa.drv: Make functions static where possible. - winex11.drv: Make get_unix_file_name() static. - dinput: Remove WINAPI on static functions where not needed. - dinput/tests: Remove WINAPI on static functions where not needed. - crypt32: Remove WINAPI on static functions where not needed. - windows.media.speech: Remove WINAPI on static functions where not needed. - winexinput.sys: Remove WINAPI on static functions where not needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/743

2 8

[PATCH v3 0/3] MR742: winevulkan: Get rid of unix_funcs.
by Jacek Caban (＠jacek) 31 Aug '22

31 Aug '22

-- v3: winevulkan: Get rid of unix_funcs. winevulkan: Use __wine_unix_call for checking Vulkan functions availability. winevulkan: Use vk_unix_call in loader.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/742

2 4

[PATCH 0/1] MR730: user32: Implement DefRawInputProc.
by Andrey Gusev (＠agusev) 31 Aug '22

31 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/730

3 5

[PATCH v4 0/6] MR492: Enhancements for C++ symbols undecoration
by eric pouech (＠epo) 31 Aug '22

31 Aug '22

This series implements a couple of enhancements to symbol undecoration in msvcrt: - more C++ constructs are correctly supported (pointer to member, constructors/destructors from template class, non-type function pointer template parameter...) - some internal cleanups & simplification (most of them based on revamped helper to build up the undecorated C++ symbols) -- v4: dlls/msvcrt: Fix order of extended qualifiers and qualifiers dlls/msvcrt: Use enum to clarify post-processing actions. dlls/msvcrt: Undecorate function signature as template argument. dlls/msvcrt: Fix white space output for typecast operator. dlls/msvcrt: Improve support for template in methods. dlls/msvcrt: Correctly support space generation in pointers. https://gitlab.winehq.org/wine/wine/-/merge_requests/492

3 9

[PATCH v2 0/4] MR742: winevulkan: Get rid of unix_funcs.
by Jacek Caban (＠jacek) 31 Aug '22

31 Aug '22

-- v2: winevulkan: Get rid of unix_funcs. winevulkan: Use __wine_unix_call for checking Vulkan functions availability. winevulkan: Use vk_unix_call in loader.c. gitlab: Run make_vulkan before building Wine. https://gitlab.winehq.org/wine/wine/-/merge_requests/742

2 4

[PATCH 0/3] MR742: winevulkan: Get rid of unix_funcs.
by Jacek Caban (＠jacek) 31 Aug '22

31 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/742

2 3