- Wine-gitlab - list.winehq.org

[PATCH v8 0/8] MR706: Draft: ntoskrnl: implement cmp instruction with opcodes 0x38,0x39
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Aug '22

24 Aug '22

fixes bug #48988 I am not very familiar with assembly, so feedback is appreciated -- v8: check correct number of bytes https://gitlab.winehq.org/wine/wine/-/merge_requests/706

2 8

[PATCH v7 0/7] MR706: Draft: ntoskrnl: implement cmp instruction with opcodes 0x38,0x39
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Aug '22

24 Aug '22

fixes bug #48988 I am not very familiar with assembly, so feedback is appreciated -- v7: fix missing newline https://gitlab.winehq.org/wine/wine/-/merge_requests/706

3 9

[PATCH 0/2] MR707: shell32: Return NULL from ExtractIcon() for all error cases.
by Brendan Shanks (＠bshanks) 24 Aug '22

24 Aug '22

Windows documents ExtractIcon() as [returning 1 in the case of an invalid file path](https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shella…, but from the tests this does not seem to be true. Return NULL for all error cases (invalid path or no icons in file). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/707

2 2

Re: [PATCH v4 0/7] MR702: windows.media.speech: Fix test breakage and misc changes.
by Bernhard Kölbl 24 Aug '22

24 Aug '22

For some reason, Marvin didn't pick up my force pushed changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/702#note_6861

1 0

[PATCH v6 0/6] MR706: Draft: ntoskrnl: implement cmp instruction with opcodes 0x38,0x39
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Aug '22

24 Aug '22

fixes bug #48988 I am not very familiar with assembly, so feedback is appreciated -- v6: remove extra space https://gitlab.winehq.org/wine/wine/-/merge_requests/706

3 8

[PATCH v3 0/3] MR706: Draft: ntoskrnl: implement cmp instruction with opcodes 0x38,0x39
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Aug '22

24 Aug '22

fixes bug #48988 I am not very familiar with assembly, so feedback is appreciated -- v3: fix print formatting https://gitlab.winehq.org/wine/wine/-/merge_requests/706

2 3

[PATCH v2 0/2] MR706: Draft: ntoskrnl: implement cmp instruction with opcodes 0x38,0x39
by Etaash Mathamsetty (＠etaash.mathamsetty) 24 Aug '22

24 Aug '22

fixes bug #48988 I am not very familiar with assembly, so feedback is appreciated -- v2: maybe fixes error? https://gitlab.winehq.org/wine/wine/-/merge_requests/706

2 2

Re: [PATCH v2 0/1] MR678: ntdll: Implement RtlRestoreContext on i386
by Alexandre Julliard (＠julliard) 24 Aug '22

24 Aug '22

> This was already committed, but is this really correct? I'm not seeing RtlRestoreContext exported from i386 kernel32 or ntdll on my Windows 10 machine. (Maybe it's out of date, though? I have Windows 10 version 21H2, build 19044.1826.) Yes, it was added fairly recently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/678#note_6852

2 1

[PATCH 0/1] MR678: ntdll: Implement RtlRestoreContext on i386
by Jakub Staroń 24 Aug '22

24 Aug '22

CoreCLR since .NET 6 (https://github.com/dotnet/runtime/pull/65490) started using `CopyContext` on x86 in it's [RestoreContextSimulated](https://github.com/dotnet/runtime/blob/55fb7ef977e…, which broke wine support. I'm not completely sure why, but I don't think its worth fixing as it's just a workaround anyways. Instead we can just use the fact that coreclr will [load](https://github.com/dotnet/runtime/blob/55fb7ef977e7d120dc12f0960edcff… the undocumented and not included in any headers x86 RtlRestoreContext. I implemented it as a simple `NtContinue` which works good enough for coreclr. The function is not used by MSVC (presumably to keep [compatibility with windows 7](https://github.com/dotnet/runtime/pull/65490#issuecomment-1043560394)) like x64/arm variants are so it shouldn't need anything else. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/678

3 9

[PATCH 0/1] MR705: combase: Omit thread ID from the stub manager ipid for MTA objects.
by Connor McAdams (＠cmcadams) 24 Aug '22

24 Aug '22

Fixes a bug that occurs when: - `CoInitializeEx(NULL, COINIT_MULTITHREADED);` is called on thread 1 - `CoInitializeEx(NULL, COINIT_MULTITHREADED);` is called on thread 2 - `CoUninitialize()` is called on thread 1. - `CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);` is called on thread 1. After this, when attempting to marshal an interface on thread 2, when `ipid_to_ifstub` is called, `apartment_findfromtid()` will find thread 1's STA and not the MTA. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/705

3 3