- Wine-gitlab - list.winehq.org

[PATCH v2 0/3] MR693: user32: Fix passing resource IDs to bitmap and icon static control
by Jacek Caban (＠jacek) 22 Aug '22

22 Aug '22

-- v2: user32: Pass resource ID as a string in DIALOG_CreateControls32. user32: Support passing bitmap and icon resource ID as a string when creating static conctrol. user32: Support resource ID strings in CREATESTRUCT Unicode conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/693

3 6

[PATCH 0/8] MR9: vkd3d-shader/hlsl: Properly check argument counts and offset dimensions in texture methods.
by Francisco Casas (＠fcasas) 22 Aug '22

22 Aug '22

The objective of this patch series is to converge to the correct argument count checks and offset parameter dimensions when parsing the Load, Sample, SampleLevel, Gather (and variants) methods, for the different texture types. I made the following table to summarize the expected arguments and their dimensions: ![resource_methods_dims](/uploads/43511fe82e934c2542f6152f9134cb0e/resource_methods_dims.png) Getting these required some extensive trial-and-error, because: - Official documentation about the methods is spread in different pages and in a somewhat inconsistent manner. - Automatic vector truncation, scalar broadcasting, and type conversion, make shaders that pass inexact types compile. - clamp and status arguments (for tiled resources) are not present in fxc 9, and yet, they are part of ps_5_0 and vs_5_0. - Some methods (Load() in particular) require the mipmap level as part of the location parameter (except for Multi-Sampled textures), while other don't. For implementing new methods I recommend passing an invalid parameter count to them in fxc 10, so that it lists available overloads. And to do this for each texture type. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/9

5 16

[PATCH v4 0/3] MR617: Draft: server: Always prefer synchronous I/O in nonblocking mode. (#53486)
by Jinoh Kang (＠iamahuman) 22 Aug '22

22 Aug '22

foobar2000.exe's UPnP Media Renderer component (foo_out_upnp.dll) expects that, if a select() call completes successfully with a non-empty writefds set, any immediately following send() call on a socket in the writefds set never fails with WSAEWOULDBLOCK. On Wine, the Winsock select() and send() implementations both call the Unix poll(2) under the hood to test if I/O is possible on the socket. As it turns out, it's entirely possible that Unix poll() may yield POLLOUT on the first call (for select) but *not* the second (for send), even if no send() call has been made in the meanwhile. On Linux (as of v5.19), a connected (ESTABLISHED) TCP socket that has not been shut down indicates the (E)POLLOUT condition only if the ratio of sk_wmem_queued (the amount of bytes queued in the send buffer) to sk_sndbuf (the size of send buffer size itself, which can be retrieved via SO_SNDBUF) is below a certain threshold. Therefore, a falling edge in POLLOUT can be triggered due to a number of reasons: 1. TCP retransmission and control packets (e.g. MTU probing). Such packets share the same buffer with application-initiated packets, and thus counted in sk_wmem_queued_add just like application data. See also: sk_wmem_queued_add() callers (Linux 5.19). 2. Memory pressure. This causes sk_sndbuf to shrink. See also: sk_stream_moderate_sndbuf() callers (Linux 5.19). Fix this by always attempting synchronous I/O first if the nonblocking flag is set. Note: for diagnosis, `getsockopt(fd, SOL_SOCKET, SO_MEMINFO, ...)` can be used to retrieve both sk_wmem_queued (the amount of bytes queued in the send buffer) and sk_sndbuf (the size of the send buffer itself, which can also be retrieved via SO_SNDBUF). -- v4: server: Always prefer synchronous I/O in nonblocking mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/617

3 4

[PATCH 0/2] MR693: user32: Fix passing resource IDs to bitmap and icon static control
by Jacek Caban (＠jacek) 22 Aug '22

22 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/693

3 5

[PATCH 0/1] MR694: bcrypt: Support ECDH_P384 key import/export.
by Hans Leidekker (＠hans) 22 Aug '22

22 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/694

2 1

[PATCH 0/1] MR683: mshtml: Handle S_FALSE return values from IUri methods.
by Gabriel Ivăncescu 22 Aug '22

22 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/683

2 2

[PATCH 0/1] MR692: scrrun: Added DateCreated property for IFile.
by Robert Wilhelm (＠sloper42) 22 Aug '22

22 Aug '22

This is similar to Nikolay��s DateLastModified patch: https://gitlab.winehq.org/wine/wine/-/commit/f6016609e1709acf8a843bc714bc7f… Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=42857 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/692

3 2

[PATCH 0/4] MR689: mmdevapi/tests: Assorted fail messages fixes.
by Davide Beatrici (＠davidebeatrici) 22 Aug '22

22 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/689

4 8

Re: [PATCH v7 0/1] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) 22 Aug '22

22 Aug '22

On Mon Aug 22 05:42:07 2022 +0000, Davide Beatrici wrote: > I replaced `button[2].iBitmap = HIST_UP` with `button[2].iBitmap = > HIST_VIEWTREE + 1`, this is the result: > ![](/uploads/6af132b1ea3c302eaeb1cc5a67945b12/image.png) Is that running on your machine? I'm testing in a Docker container. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6657

1 0

[PATCH v3 0/1] MR687: winealsa: Fix WoW64 failure when calling get_position().
by Davide Beatrici (＠davidebeatrici) 22 Aug '22

22 Aug '22

Bug introduced in !600. ``` 00dc:trace:alsa:AudioClient_GetService (00A53680)->({cd63314f-3fba-4a1b-812c-ef96358728e7}, 0022FCB0) 00dc:trace:alsa:AudioClient_AddRef (00A53680) Refcount now 2 00dc:trace:alsa:AudioClock_GetFrequency (00A53680)->(0022FCC8) render.c:1056: Clock Frequency 384000 00dc:trace:alsa:AudioClock_GetPosition (00A53680)->(00000000, 00000000) 00dc:trace:alsa:AudioClock_GetPosition (00A53680)->(0022FCD0, 0022FCD8) 00dc:trace:alsa:alsa_get_position frames written: 0, held: 0, state: 0x2, position: 0 render.c:1071: Test failed: GetPosition failed: 00423930 render.c:1072: Test failed: GetPosition returned non-zero pos before being started render.c:1073: Test failed: GetPosition returned zero pcpos 00dc:trace:alsa:AudioClient_GetService (00A53680)->({f294acfc-3146-4483-a7bf-addca7c260e2}, 0022FCB4) 00dc:trace:alsa:AudioClient_AddRef (00A53680) Refcount now 3 00dc:trace:alsa:AudioRenderClient_GetBuffer (00A53680)->(24001, 0022FCC0) ``` And then `mmdevapi_test` hangs. About WoW64 testing: !688 -- v3: winealsa: Fix WoW64 failure when calling get_position(). https://gitlab.winehq.org/wine/wine/-/merge_requests/687

3 3