- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 28 Jul '22

28 Jul '22

On Thu Jul 28 03:42:04 2022 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=119994 > Your paranoid android. > === debian11 (32 bit report) === > comctl32: > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > === debian11 (32 bit Chinese:China report) === > comctl32: > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > === debian11 (32 bit WoW report) === > comctl32: > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > === debian11 (64 bit WoW report) === > comctl32: > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3578: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > listview.c:3595: Test succeeded inside todo block: ownerdata select > multiple notification: marked "todo_wine" but succeeds > ``` Should be fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5203

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 28 Jul '22

28 Jul '22

On Thu Jul 28 03:52:03 2022 +0000, Zhiyi Zhang wrote: > It seems that you forgot to remove these todo_wines. Sorry that slipped through. Should be fixed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5202

1 0

[PATCH 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 28 Jul '22

28 Jul '22

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. I removed the `Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>` as I am unsure what the custom is. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 7

Re: [PATCH v7 0/9] MR538: mshtml: Implement more methods for Elements. - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/538

1 0

Re: [PATCH v5 0/5] MR531: win32u: Add more rawinput tests and fix HID device regression. - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/531

1 0

Re: [PATCH v2 0/1] MR527: mshtml/tests: Fix date_now test. - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/527

1 0

Re: [PATCH v2 0/4] MR547: vulkan: Don't expose driver interface to PE code and use syscall interface for more functions. - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/547

1 0

Re: [PATCH v3 0/2] MR541: winedbg: Prefer thread names from GetThreadDescription(). - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/541

1 0

Re: [PATCH v5 0/4] MR406: win32u: Introduce new add_modes device manager callback. - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/406

1 0

Re: [PATCH v2 0/1] MR548: regedit: Use zero as a default for REG_DWORD and REG_QWORD values - approved
by Alexandre Julliard (＠julliard) 27 Jul '22

27 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/548

1 0