6 Aug
2024
6 Aug
'24
10:46 a.m.
Alfred Agrell (@Alcaro) commented about dlls/advapi32/tests/eventlog.c:
} }
+ SetLastError(0xdeadbeef); + buf = (void*)0xdeadbeef;
Can't ASLR put something there by accident, making the test flaky? Wouldn't it be better to use a guaranteed-invalid address, like 0x00000001 or a VirtualAlloc(PAGE_NOACCESS)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6203#note_77869