20 Oct
2025
20 Oct
'25
9:28 p.m.
Jacek Caban (@jacek) commented about dlls/mshtml/htmlnode.c:
+{ + HTMLDOMChildrenCollection *This = impl_from_DispatchEx(dispex); + nsIDOMNode *nsnode; + HTMLDOMNode *node; + nsresult nsres; + HRESULT hres; + + nsres = nsIDOMNodeList_Item(This->nslist, index, &nsnode); + if(NS_FAILED(nsres)) + return map_nsresult(nsres); + + hres = get_node(nsnode, TRUE, &node); + nsIDOMNode_Release(nsnode); + if(SUCCEEDED(hres)) + *p = (IDispatch*)&node->IHTMLDOMNode_iface; + return hres; This duplicates `HTMLDOMChildrenCollection_item`. There is similar pattern in a few other patches, please try to avoid that.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9136#note_119107