18 Nov
2025
18 Nov
'25
7:21 a.m.
Rémi Bernon (@rbernon) commented about dlls/dmsynth/synth.c:
* whereas DLS2 uses (1200 * log2(f / 440.) + 6900) * 65536. The values * are very close but not strictly identical and we may need a conversion. */ + else if (gen == GEN_MODLFOTOVOL && src1 == FLUID_MOD_CHANNELPRESSURE) + value = conn->lScale / 655360.; else if (conn->lScale == 0x80000000) value = -32768;
Nit: ```suggestion:-2+0 else if (gen == GEN_MODLFOTOVOL && src1 == FLUID_MOD_CHANNELPRESSURE) value = conn->lScale / 655360.; else if (conn->lScale == 0x80000000) value = -32768; ``` Or add newlines to every branch, keeping them balanced is more readable IMO. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9506#note_122714