Re: [PATCH v7 0/8] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl_codegen.c:
> LIST_FOR_EACH_ENTRY(var, &ctx->extern_vars, const struct hlsl_ir_var, extern_entry)
>      {
> -        if (var->last_read && var->reg_reservation.type == hlsl_regset_name(ctx, regset)
> +        if (var->reg_reservation.type == hlsl_regset_name(ctx, regset)

Huh, interesting. I'd have thought I wrote that on purpose, but testing again now I can't seem to replicate a situation where unused objects are ignored. Or unused cbuffers for that matter.

Doesn't need to block this series, but tests for this would be good.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66#note_23483