Re: [PATCH v4 0/1] MR2390: winegstreamer: Cache wg_parser input data.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_parser.c:
> +        }
> +    }
> +
> +    return NULL;
> +}
> +
> +static gsize read_cached_chunk(struct wg_parser *parser, guint64 chunk_position, unsigned int chunk_offset, GstBuffer *buffer, guint64 buffer_offset)
> +{
> +    struct input_cache_chunk *chunk;
> +    GstBuffer *chunk_buffer;
> +    void *chunk_data;
> +    GstFlowReturn ret;
> +
> +    if ((chunk = get_cache_entry(parser, chunk_position)))
> +    {
> +        return !!gst_buffer_fill(buffer, buffer_offset, chunk->data + chunk_offset, input_cache_chunk_size - chunk_offset) ? GST_FLOW_OK : GST_FLOW_ERROR;
> This is an awfully long line; I'd just make this a normal if/else. There's another below.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2390#note_29970