Connor McAdams (@cmcadams) commented about include/xamlom.idl:
+ ErrorResolved = 0, + ErrorResourceNotFound, + ErrorInvalidResource, +} VisualElementState; + +[ + object, + uuid(aa7a8931-80e4-4fec-8f3b-553f87b4966e) +] +interface IVisualTreeServiceCallback : IUnknown +{ + HRESULT OnVisualTreeChange( + [in] ParentChildRelation relation, + [in] VisualElement element, + [in] VisualMutationType mutationType); +} In wine headers, we typically align method arguments with the method name. I.e:
``` HRESULT OnVisualTreeChange( [in] ParentChildRelation relation, [in] VisualElement element, [in] VisualMutationType mutationType); ``` Further, the `mutationType` argument name is camel case. That should probably be changed to `mutation_type`. This needs to be done for all the other interfaces as well here. Things such as `PropertyChainValue** ppPropertyValues` should be `PropertyChainValue **property_values`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2773#note_34800