11 Feb
2023
11 Feb
'23
8:30 p.m.
On Sat Feb 11 14:27:53 2023 +0000, Jinoh Kang wrote:
For accurate heap free checking, we should always assign `next = NULL` when validating LFH blocks. ```suggestion:-2+0 else { /* LFH blocks do not use BLOCK_FLAG_PREV_FREE or back pointer */ next = (block_get_flags( block ) & BLOCK_FLAG_LFH) ? NULL : next_block( subheap, block ); } if (!err && next) ``` Actually `validate_free_block` will, as of now, never be called with a LFH block as it iterates over the subheap blocks and will check the LFH group as a whole. Therefore I've removed the related checks.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1628#note_23844