30 Nov
2022
30 Nov
'22
9:31 a.m.
On Wed Nov 30 08:03:41 2022 +0000, Mohamad Al-Jaf wrote:
This could be changed to use wcsdup instead. But is it considered good practice having a fallback or should the function just fail completely if it fails to get a serial number using wbemprox? ```suggestion:-0+0 serial = wcsdup(L"0"); ``` I think it should return the failure from wbemprox. There's already a fallback there so no need to have it one here.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1588#note_17995