8 Jul
2025
8 Jul
'25
4:24 p.m.
Connor McAdams (@cmcadams) commented about dlls/setupapi/devinst.c:
BYTE *prop_buff, ULONG *prop_buff_size, ULONG flags, HMACHINE machine) { HDEVINFO set; + SP_DEVINFO_DATA data = { sizeof(data) };
I don't have a super strong opinion on this, but if you initialize this in `get_devnode_device()` instead you'd avoid the possibility in the future of accidentally leaving this uninitialized, as an example if that function is ever called from another function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109128