26 Oct
2022
26 Oct
'22
6:28 p.m.
On Wed Oct 26 18:28:12 2022 +0000, Gabriel Ivăncescu wrote:
For the second patch, I also considered doing that handling from VT_NULL to a null VT_DISPATCH in jscript using the internal ES5 version check. Let me know if that's preferrable. I'm not sure, change_type() does not seem wrong, but you unconditionally skipping IVariantChangeType is questionable. It would be interesting to add something like Invoke(attachEvent) call to test_arg_conv() and see how it behaves.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1172#note_12266