On Tue May 28 20:08:54 2024 +0000, Rémi Bernon wrote:
According to https://testbot.winehq.org/JobDetails.pl?Key=145848&f107=exe32.report&f111=e... and https://testbot.winehq.org/JobDetails.pl?Key=145849, it's not so much optional. Sure, there's a couple of success but a vast majority of failures and I'm inclined to think that whatever is going on is more a bad interaction with some other tests than really some Windows behavior. Also, I think there's something fishy going on already, on the test results above even for the few successful runs there's still plenty of failed sequences but no test failures somehow? I don't know how this can happen but it doesn't look right. Fwiw the first commit alone looks okay, if you want to get `EVENT_SYSTEM_FOREGROUND` merged. The tests tweaking would probably need more investigation. I suppose it's better than nothing, but I think more work is going to be needed on this event (I found in Proton that there were some situations where it's missing) and on the tests to make sure the Windows results are representative of typical circumstances.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853#note_71667