On Mon Feb 5 14:02:12 2024 +0000, Gabriel Ivăncescu wrote:
So I tried a bunch of things but it turns out it's pointlessly too complicated for my liking, especially since I also have to remove the trailing slash (or else tests fail), which at that point I might as well parse the whole thing. But InternetCrackUrl seems like the perfect fit, which is even simpler than my current parsing. We already use it in htmllocation.c so I think it should be fine for this purpose? I don't even have to special case the trailing slash. I think I'll go with that. Sorry I forgot to mention that I can't do this because of initMessageEvent which keeps the string as supplied and returns it, so I'd need two code paths which IMO makes it more complicated for no reason.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4986#note_60040