20 Oct
2023
20 Oct
'23
8:14 p.m.
Alexandre Julliard (@julliard) commented about tests/driver.c:
+ goto out; + } + + if (WaitForSingleObject(info.hProcess, INFINITE) != WAIT_OBJECT_0) + { + fprintf(stderr, "Cannot wait for process termination, last error %ld.\n", GetLastError()); + ret = false; + goto out; + } + + if (!GetExitCodeProcess(info.hProcess, &exit_code)) + { + fprintf(stderr, "Cannot retrive the process exit code, last error %ld.\n", GetLastError()); + ret = false; + goto out; + } This should have a (short) timeout and then kill the process, like winetest.exe does. We can't have a runaway test block the runner for an hour.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413#note_49466