Re: [PATCH 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
> +        [2] = determinant2x2,
> +        [3] = determinant3x3,
> +        [4] = determinant4x4,
> +    };
> +
> +    struct hlsl_ir_node *arg = params->args[0];
> +    const struct hlsl_type *type = arg->data_type;
> +    struct hlsl_ir_function_decl *func;
> +    unsigned int dim;
> +    char *body;
> +
> +    if (type->class != HLSL_CLASS_SCALAR && type->class != HLSL_CLASS_MATRIX)
> +    {
> +        hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_INVALID_TYPE, "Invalid argument type.");
> +        return false;
> +    }
> Can we have a bit more in the way of tests for this part? Tests for float, float1, float2, float1x1 would be nice at least.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329#note_44457