6 Sep
2024
6 Sep
'24
2:54 p.m.
Alfred Agrell (@Alcaro) commented about dlls/msvcrt/concurrency.c:
/* ?_Yield(a)_Context@details(a)Concurrency@@SAXXZ */ void __cdecl Context_Yield(void) { - FIXME("()\n"); + static unsigned int once; + + if (!once++) This function looks threading related, so that's a race condition. Probably harmless in practice, but that kinda stuff makes me nervous. (And it'll print again if it overflows.)
I recommend changing to InterlockedOr. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6454#note_81369