Re: [PATCH v8 0/8] MR707: vkd3d-shader/dxil: TGSM part 2.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> ins->handler_idx = VKD3DSIH_NOP;
>  }
>
> +static void sm6_parser_dcl_register_builtin(struct sm6_parser *sm6,
> +        enum vkd3d_shader_register_type reg_type, enum vkd3d_data_type data_type, unsigned int component_count)
> +{
> +    struct vkd3d_shader_dst_param *dst_param;
> +    struct vkd3d_shader_instruction *ins;
> +    uint64_t reg_flag;
> +
> +    reg_flag = 1ull << reg_type;

So far it's fine, but we're not far away from having 64 register types. Could we statically assert that `VKD3DSPR_COUNT < sizeof(unsigned long long) * CHAR_BIT`?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/707#note_65360