Re: [PATCH 0/5] MR6776: d3dx9: D3DXSaveSurfaceToFileInMemory() refactoring, part 1.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
> +
> +            hr = D3DXCreateBuffer(dst_slice_pitch + sizeof(*header), &buffer);
> +            if (FAILED(hr))
> +                return hr;
> +
> +            header = ID3DXBuffer_GetBufferPointer(buffer);
> +            pixels = (uint8_t *)ID3DXBuffer_GetBufferPointer(buffer) + sizeof(*header);
> +            hr = d3dx_init_dds_header(header, D3DRTYPE_TEXTURE, dst_format, &src_pixels->size, 1);
> +            if (FAILED(hr))
> +                goto exit;
> +            break;
> +        }
> +
> +        default:
> +            assert(0);
> +            break;
> This suggestion is probably going to be a bit much in respect to what's usual for Wine, so feel free to ignore it. I'd personally go for something like:
            assert(0 && "Unexpected file format");
            return E_FAIL;

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6776#note_86948