Jacek Caban (@jacek) commented about dlls/mshtml/tests/script.c:
ok(dst != NULL, "dst = NULL\n"); ok(V_VT(dst) == VT_EMPTY, "V_VT(dst) = %d\n", V_VT(dst)); ok(src != NULL, "src = NULL\n"); + ok(lcid == LOCALE_NEUTRAL, "lcid = %ld\n", lcid); + if(ChangeType_expect_null_dispatch) { + ok(V_VT(src) == VT_NULL, "V_VT(src) = %d\n", V_VT(src)); + ok(vt == VT_DISPATCH, "vt = %d\n", vt); + /* native jscript returns E_NOTIMPL, use a "valid" error to test that it doesn't matter */ + return E_OUTOFMEMORY; + }
I think it would be better to avoid having ChangeType_expect_null_dispatch, you could just structure it like: ``` switch(vt) { case VT_BSTR: CHECK_EXPECT(ChangeType_bstr); .... case VT_DISPATCH: CHECK_EXPECT(ChangeType_dispatch); .... default: ok(0, "unexpected vt %u", vt); } ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1172#note_12484