Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux

[Francois Gouget (＠fgouget)]

Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c:
> +            req->icmp_seq = icmp_h->un.echo.sequence;
> +            if (!(fixup_status = wine_server_call( req )))
> +                icmp_h->un.echo.id = reply->icmp_id;
> +            else
> +                WARN( "socket_get_fixup_data returned %#x.\n", fixup_status );
> +        }
> +        SERVER_END_REQ;
> +
> +        if (!fixup_status)
> +        {
> +            icmp_h->checksum = 0;
> +            icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - sizeof(ip_h) );
> +        }
> +    }
> +    ip_h.checksum = 0;
> +    ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) );
> Isn't the first assignment redundant?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796