Re: [PATCH v10 0/1] MR7052: vbscript: implement Join()

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> +            break;
> +        default:
> +            return MAKE_VBSERROR(VBSE_TYPE_MISMATCH);
> +    }
> +
> +    if (args_cnt == 2) {
> +        if (V_VT(args + 1) == VT_NULL)
> +            return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE);
> +        if (V_VT(args + 1) != VT_BSTR) {
> +            hres = to_string(args + 1, &free_delimiter);
> +            if (FAILED(hres))
> +                return hres;
> +            delimiter = free_delimiter;
> +            delimiter_len = SysStringLen(free_delimiter);
> +        } else {
> +            delimiter = V_BSTR(args + 1);
> I think we should set `delimiter_len` here as well.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_93562