18 Jan
2023
18 Jan
'23
1 p.m.
On Wed Jan 18 11:11:53 2023 +0000, Jinoh Kang wrote:
The `ichCurrent < 0` case is not tested. Assuming it triggers undefined behaviour on Windows, it's hard to add working tests for it. Since this code is untested, you should just remove the `ichCurrent < 0`. Maybe add `assert(ichCurrent < 0);` if you're genuinely worried. Tests that are broken on Windows are ran on Wine for what it's worth, `ichCurrent < 0` in particular is tested by `work_break_proc(some_pathW, -10, 0, WB_LEFT)`, which on Windows gets stuck in a loop.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1977#note_21129