Re: [PATCH v2 0/1] MR8971: make_unicode: Add some halfwidth mapping exceptions.

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about dlls/kernel32/tests/locale.c:
> ok(!ret, "%s func_ptr should fail with srclen = 0\n", func_name);
>      ok(GetLastError() == ERROR_INVALID_PARAMETER,
>         "%s unexpected error code %ld\n", func_name, GetLastError());
> +
> +    /* test for characters which don't get mapped to their
> +       halfwidth counterparts on LCMAP_HALFWIDTH */
> +    buf[0] = buf2[0] = L'→';
> +    buf[1] = buf2[1] = L'○';

Please use hex sequences instead of Unicode chars.

I don't think it makes much sense to change just one of the arrows, you should at least test them all.

What app depends on this?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8971#note_115851