Re: [PATCH v4 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW

[Alex Henrie (＠alexhenrie)]

Alex Henrie (@alexhenrie) commented about dlls/setupapi/query.c:
> return FALSE;
>  }
>
> +HRESULT WINAPI DriverStoreFindDriverPackageW(const WCHAR *path_in, void *unk2, void *unk3, DWORD flags, void *unk5, WCHAR *path_out, DWORD *path_size)
> +{
> +    FIXME("%s, %p, %p, %lu, %p, %p, %p, %lu stub!\n", debugstr_w(path_in), unk2, unk3, flags, unk5, path_out, path_size, path_size ? *path_size : 0);
> +    if (!path_in || !path_out || !path_size || *path_size < 260)

Personally I would prefer `*path_size < MAX_PATH` instead of `*path_size < 260`, but it's a matter of taste. What you wrote is fine.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52468