On Sat Aug 26 03:12:03 2023 +0000, Jeffrey Smith wrote:
@gang65 Returning an error here is an implementation detail. I don't even know that native uses GetDIBits. I do know that this implementation does, and something reasonable should be done when a bad value is returned. Finding conditions that cause native to break and testing those is one thing, but unless you have something specific in mind already, I don't see the need for additional testing here. If number of copied lines from bitmap is zero, we should keep previous behaviour and return `Ok`.
Otherwise we could introduce regression. I think returning Error without covering it with tests is very risky. More info: https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-getdibi... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3657#note_43484