19 Jan
2024
19 Jan
'24
7:19 p.m.
I think I like the syntax as it is, at least I agree with the changes that have been made, but: * Do we really want to invent a new set of names like that for sysval? Should we just clip VKD3D_SHADER_SV from the existing enum instead? * What's the plan for GS stream index and for minimum precision? * Any reason we're leaving out patch constant signatures from this series?
From patch 4/6:
+ if (ret >= 0) + vkd3d_string_buffer_printf(buffer, ".section SHEX\n");
This feels weird, partly because it's in dump_signatures(), also because I don't see why it's SHEX and not SHDR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553#note_58214