22 Jan
2024
22 Jan
'24
8:31 p.m.
Francisco Casas (@fcasas) commented about libs/vkd3d-shader/ir.c:
case VKD3DSIH_DCL_TEMPS: vsir_validate_dst_count(ctx, instruction, 0); vsir_validate_src_count(ctx, instruction, 0); - if (ctx->dcl_temps_found) - validator_error(ctx, VKD3D_SHADER_ERROR_VSIR_DUPLICATE_DCL_TEMPS, "Duplicate DCL_TEMPS instruction.");
It is necessary to remove `dcl_temps_found`? It may still be useful to detect duplicated DCL_TEMPS instructions. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/574#note_58465