Re: [PATCH 0/8] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> LIST_FOR_EACH_ENTRY(var, &ctx->extern_vars, struct hlsl_ir_var, extern_entry)
>      {
>          unsigned int width = (1u << var->data_type->dimx) - 1, use_mask;
> -        enum vkd3d_sm4_register_type type;
> +        enum vkd3d_shader_register_type type;

It doesn't look like this variable is really used. Maybe you can just drop it (and fix `hlsl_sm4_register_from_semantic()` so that it accepts `NULL` for `type`). While you're at it, maybe variable `type` could be retyped to `enum vkd3d_shader_register_type *`.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281#note_39585