11 Sep
2023
11 Sep
'23
11:23 a.m.
Given that `hlsl_add_conditional()` is also used in `lower_int_division()` and `lower_int_modulus()`, which likely have the same problem, shouldn't we rather fix `hlsl_add_conditional()` instead? Also, please add the corresponding test in `arithmetic-float-uniform.shader_test` too: ```c [pixel shader] float4 x = {5.0, -42.1, 4.0, 45.0}; float4 y = {15.0, -5.0, 4.1, 5.0}; float4 main() : sv_target { return x % y; } [test] draw quad probe all rgba (5.0, -2.1, 4.0, 0.0) 4 ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/336#note_44878