8 Feb
2024
8 Feb
'24
11:19 a.m.
I think this is essentially fine like this. Two small nits: - We usually have a blank line between the declarations and the TRACE. - We usually have a full stop at the end of the TRACE. I.e., "iface %p, min %.8e, max %.8e.\n" Compare e.g. d3d12_command_list_OMSetBlendFactor() and d3d12_command_list_OMSetStencilRef(). In any case, does this need to remain a draft MR? I think it's fine to wait for the tests, but wouldn't mind merging this as-is either. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_60594