Re: [PATCH 0/1] MR1987: Draft: webservices/tests: Move firewall code to a common header.

[Hans Leidekker (＠hans)]

On Thu Jan 19 15:36:40 2023 +0000, Jinoh Kang wrote:
> The order of tests are swapped.
> ```suggestion:-1+0
>     if (!winetest_is_firewall_enabled()) return TRUE;
>     if (!winetest_is_process_elevated()) return FALSE;
> ```
> That said, is the process elevation check still needed? If accessing
> NetFw APIs causes Windows to show a warning dialog or has other
> undesirable side effects, that should certainly be avoided. Otherwise,
> we could just use the "ask for forgiveness, not permission" approach,
> since we no longer have `ok()` tests for calls anymore.
> Thanks, I'll fix the order. Without the elevation check the firewall dialog pops up.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1987#note_21216