22 Nov
2024
22 Nov
'24
4:23 p.m.
On Fri Nov 22 16:18:58 2024 +0000, Jinoh Kang wrote:
The error check is missing. Copying from above: ```suggestion:-0+0 ret = DeleteFileA(dest); ok(!ret, "DeleteFileA: error %ld\n", GetLastError()); ``` Deletion failures sometimes happen due to e.g., unexpectedly open handles w/o FILE\_SHARE\_DELETE, and leftover files interfere with successive tests that assume clean slate. For some reason this returns non-zero for me on Windows, even though it deletes the file. So I assumed it's flaky in some way? Does it not for you?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6855#note_88543