29 Jun
2023
29 Jun
'23
12:56 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
+{ + unsigned int i, j, count, type_count, type_index; + const struct dxil_record *record; + const struct dxil_block *block; + char *struct_name = NULL; + struct sm6_type *type; + uint64_t type_id; + bool is_unique; + + if (!(block = sm6_parser_get_level_one_block(sm6, TYPE_BLOCK, &is_unique))) + { + WARN("No type definitions found.\n"); + return VKD3D_OK; + } + if (!is_unique) + FIXME("Ignoring extra type table(s).\n"); Is this a `FIXME()` because it can be legal to have more than one type table?
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/259#note_37317