Re: [PATCH v7 0/8] MR1628: ntdll: Implement Low Fragmentation Heap.

[Rémi Bernon]

On Mon Feb  6 15:54:46 2023 +0000, Jinoh Kang wrote:
> I think it helps readability to hoist the type checks (dead and free)
> common to both LFH and non-LFH.
> ```suggestion:-9+0
>     else if (block_get_type( block ) == BLOCK_TYPE_DEAD)
>         err = "delayed freed block";
>     else if (block_get_type( block ) == BLOCK_TYPE_FREE)
>         err = "already freed block";
>     else if (block_get_flags( block ) & BLOCK_FLAG_LFH)
>     {
>         if (block_get_type( block ) != BLOCK_TYPE_USED)
>             err = "invalid block type";
>         /* NOTE: A LFH block does not have a subheap (its base points to
> a group instead) */
>     }
> ```
> Done.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1628#note_23254