Re: [PATCH v5 0/7] MR391: scrrun: Implement MoveFolder().

8 Jul 2022

On Thu Jul  7 20:21:24 2022 +0000, **** wrote:
...
Dmitry Timoshkov replied on the mailing list:
```
Robert Wilhelm <wine(a)gitlab.winehq.org> wrote:
...

--- a/dlls/scrrun/tests/filesystem.c
+++ b/dlls/scrrun/tests/filesystem.c
@@ -2605,6 +2605,7 @@ static void test_MoveFolder(void)
     BSTR src, dst, str, empty;
     WCHAR buffW1[MAX_PATH],buffW2[MAX_PATH];
     HRESULT hr;
+    File *file;
get_temp_path(L"foo", buffW1);
     get_temp_path(L"bar", buffW2);
@@ -2648,6 +2649,19 @@ static void test_MoveFolder(void)
     ok(hr == CTL_E_PATHNOTFOUND, "Unexpected hr %#lx.\n", hr);
     SysFreeString(src);
     SysFreeString(dst);
+
+    file = CreateFileW(buffW1, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS,
+                       FILE_ATTRIBUTE_NORMAL, NULL);
+    ok(file != INVALID_HANDLE_VALUE, "CreateFile failed\n");
+    CloseHandle(file);
'file' should have type HANDLE in this case.
-- 
Dmitry.
Hi Dmitry. Thanks for spotting this. I have pushed v5 MR with this change.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_3595

    

Re: [PATCH v5 0/7] MR391: scrrun: Implement MoveFolder().

Robert Wilhelm (＠sloper42)