10 Jul
2025
10 Jul
'25
11:05 a.m.
Zhiyi Zhang (@zhiyi) commented about dlls/kernel32/tests/file.c:
ok( ret == TRUE, "got error %lu\n", GetLastError() ); }
+static BOOL create_manifest_file(const char *filename) +{ + DWORD size; + HANDLE file; + + file = CreateFileA(filename, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, + FILE_ATTRIBUTE_NORMAL, NULL); + ok(file != INVALID_HANDLE_VALUE, "CreateFile failed: %lu\n", GetLastError()); + if(file == INVALID_HANDLE_VALUE)
Space after `if`. Same at other places. In fact, I think you can just delete this `if`. If CreateFileA() fails, there is already the ok() check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_109452