Re: [PATCH v2 0/2] MR8555: windows.devices.enumeration: Reimplement DeviceInformationStatics::FindAllAsync and DeviceWatcher using the device query API.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/windows.devices.enumeration/main.c:
> EnterCriticalSection( &impl->cs );
>      switch (impl->status)
>      {
> -    case DeviceWatcherStatus_EnumerationCompleted: hr = E_ILLEGAL_METHOD_CALL; break;
> -    case DeviceWatcherStatus_Started: hr = E_ILLEGAL_METHOD_CALL; break;
> -    case DeviceWatcherStatus_Stopping: hr = E_ILLEGAL_METHOD_CALL; break;
> -    default: hr = E_ILLEGAL_METHOD_CALL;

Same comment as the before wrt. default case for the state machine. Actually, I wouldn't mind if you added a separate commit to change the `default: hr = E_ILLEGAL_METHOD_CALL;` into `default: assert( 0 ); break;` here and there, the fallthrough looks wrong.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8555#note_111630